Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sabnzbd: update to 3.2.1 #30175

Closed
wants to merge 2 commits into from
Closed

Conversation

vaft22
Copy link

@vaft22 vaft22 commented Apr 12, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr
Copy link
Member

ericonr commented Apr 12, 2021

Please add python3-Cheroot explicitly to depends :)

@vaft22
Copy link
Author

vaft22 commented Apr 13, 2021

Please add python3-Cheroot explicitly to depends :)

May I ask why this should be? I checked Debian, Arch, and Gentoo packages, and they all use the same dependency format: sabnzbd depends on python3-CherryPy, and python3-CherryPy depends on python3-Cheroot.

@ericonr
Copy link
Member

ericonr commented Apr 13, 2021

Sorry, I should have linked it! It might be nice to include the link in the commit message, even:

https://github.com/sabnzbd/sabnzbd/blob/3.2.1/requirements.txt

The reasoning being that if cherrypy changes its dependencies, cheroot will still be available for sabnzbd :)

@ericonr ericonr closed this in 7c1f60d Apr 14, 2021
@ericonr
Copy link
Member

ericonr commented Apr 14, 2021

I squashed the commits locally and pushed, thanks!

@vaft22 vaft22 deleted the sabnzbd-branch branch April 15, 2021 02:30
hazayan pushed a commit to hazayan/void-packages that referenced this pull request Apr 15, 2021
Also add dependency python3-Cheroot, per requirements.txt:
https://github.com/sabnzbd/sabnzbd/blob/3.2.1/requirements.txt

Closes: void-linux#30175 [via git-merge-pr]
Logarithmus pushed a commit to Logarithmus/void-packages that referenced this pull request May 5, 2021
Also add dependency python3-Cheroot, per requirements.txt:
https://github.com/sabnzbd/sabnzbd/blob/3.2.1/requirements.txt

Closes: void-linux#30175 [via git-merge-pr]
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants