Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: update to 90.0.4430.72. #30271

Closed
wants to merge 2 commits into from
Closed

Conversation

pbui
Copy link
Contributor

@pbui pbui commented Apr 16, 2021

[ci skip]

  • Built for x86_64, i686, x86_64-musl.

  • Tested on x86_64.

  • Removes API key. Popups a warning message on startup that certain features are disabled, but most normal browsing continues to work. The message links the following: https://www.chromium.org/developers/how-tos/api-keys

  • Also update chromium-widevine.

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@pbui pbui changed the title chromium: update to 90.0.4430.72. [WIP] chromium: update to 90.0.4430.72. Apr 16, 2021
@pbui
Copy link
Contributor Author

pbui commented Apr 16, 2021

@q66 Please review the changes to xxx-ppc64le-support.patch.

@ericonr The musl build fails due to the use of pthread_getname_np in third_party/perfetto/include/perfetto/ext/base/thread_utils.h

@ericonr
Copy link
Member

ericonr commented Apr 16, 2021

diff --git a/include/perfetto/ext/base/thread_utils.h b/include/perfetto/ext/base/thread_utils.h
index fb47d3d..d346e66 100644
--- a/include/perfetto/ext/base/thread_utils.h
+++ b/include/perfetto/ext/base/thread_utils.h
@@ -58,7 +58,7 @@ inline bool MaybeSetThreadName(const std::string& name) {
 
 inline bool GetThreadName(std::string& out_result) {
   char buf[16] = {};
-#if PERFETTO_BUILDFLAG(PERFETTO_OS_ANDROID)
+#if 1
   if (prctl(PR_GET_NAME, buf) != 0)
     return false;
 #else

@pbui
Copy link
Contributor Author

pbui commented Apr 17, 2021

@ericonr x86_64-musl builds now. I have uploaded my build here: https://h4x0r.space/

- Built for x86_64, i686, x86_64-musl.
- Tested on x86_64.

- Removes API key.
@pbui pbui changed the title [WIP] chromium: update to 90.0.4430.72. chromium: update to 90.0.4430.72. Apr 17, 2021
@q66
Copy link
Contributor

q66 commented Apr 18, 2021

made it build on ppc64le-musl, but it does not work (tabs crash) - was it tested on x86_64-musl at all?

@ericonr
Copy link
Member

ericonr commented Apr 18, 2021

Confirmed working on x86_64-musl with youtube and tinkercad

@q66 q66 closed this in 25a2511 Apr 20, 2021
Logarithmus pushed a commit to Logarithmus/void-packages that referenced this pull request May 5, 2021
- Built for x86_64, i686, x86_64-musl.
- Tested on x86_64.

- Removes API key.
- Changes by q66: ppc patch fixes

Closes void-linux#30271
hazayan pushed a commit to hazayan/void-packages that referenced this pull request May 9, 2021
- Built for x86_64, i686, x86_64-musl.
- Tested on x86_64.

- Removes API key.
- Changes by q66: ppc patch fixes

Closes void-linux#30271
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants