New package: newsflash-1.4.2 #30449
Merged
New package: newsflash-1.4.2 #30449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paper42
force-pushed
the
0084-New-package-newsflash-1.4.0.patch
branch
from
e6ef288
to
12d5232
Compare
|
Could someone who knows a bit more about rust help me with this? With a cargo style I get this error for x86_64 and this for cross compilation to aarch64-musl: When I use meson build style and add rust-std to makedepends I get a different error on aarch64-musl cross compilation (x86_64 and i686 works fine): |
|
I think it's expected to build with meson, which will generate the file with the version info, maybe? So try adding |
paper42
force-pushed
the
0084-New-package-newsflash-1.4.0.patch
branch
from
12d5232
to
3438a6e
Compare
|
#24218 can be closed then |
|
Why not call it |
I think newsflash makes more sense:
|
|
Ok, that makes sense. Have you verified that an |
paper42
force-pushed
the
0084-New-package-newsflash-1.4.0.patch
branch
from
3438a6e
to
9db4e9b
Compare
Just fixed it with an update :) |
|
this update needs newer rust |
paper42
force-pushed
the
0084-New-package-newsflash-1.4.0.patch
branch
from
9db4e9b
to
3705701
Compare
ericonr
reviewed
Jul 9, 2021
srcpkgs/newsflash/template
Outdated
Comment on lines
19
to
20
| vsed -i build-aux/cargo.sh \ | ||
| -e 's,"$CARGO_TARGET_DIR"/${TARGET}/news_flash_gtk,"$CARGO_TARGET_DIR"/'"${XBPS_CROSS_RUST_TARGET}/"'${TARGET}/news_flash_gtk,' |
There was a problem hiding this comment.
Please use the same sed as https://github.com/void-linux/void-packages/pull/24218/files
Is the CARGO_HOME one not necessary?
paper42
force-pushed
the
0084-New-package-newsflash-1.4.0.patch
branch
from
3705701
to
b5f9deb
Compare
|
Your post-patch section is different from #24218 e.g. you have "," instead of "/". |
paper42
force-pushed
the
0084-New-package-newsflash-1.4.0.patch
branch
from
b5f9deb
to
7c328b2
Compare
@notthewave Thanks for noticing this, I am not sure why I missed it. We don't need to remove the CARGO_HOME line anyway, not sure why, but it works without patching it, there is probably a variable which has higher priority (maybe CARGO_TARGET_DIR?). I couldn't find it mentioned in the documentation, but it works fine. The CI is still failing for some architectures, because cargo.io is unreliable. |
ericonr
reviewed
Jul 14, 2021
srcpkgs/newsflash/template
Outdated
| makedepends="rust-std webkit2gtk-devel libhandy1-devel openssl-devel" | ||
| short_desc="RSS feed reader that supports various web based services" | ||
| maintainer="Michal Vasilek <michal@vasilek.cz>" | ||
| license="GPL-3.0-only" |
There was a problem hiding this comment.
It seems to be "or-later" https://gitlab.com/news-flash/news_flash_gtk/-/issues/222
ericonr
force-pushed
the
0084-New-package-newsflash-1.4.0.patch
branch
from
7c328b2
to
90f9d93
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
Have the results of the proposed changes been tested?