Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: python3-poetry-core-1.0.3 #30552

Closed
wants to merge 2 commits into from

Conversation

kwshi
Copy link
Contributor

@kwshi kwshi commented Apr 27, 2021

  • New package: python3-poetry-core
  • Manual.md: add instructions for Poetry-built Python packages

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

Manual.md Outdated Show resolved Hide resolved
@kwshi
Copy link
Contributor Author

kwshi commented Apr 27, 2021

Resolves #30551

Manual.md Outdated Show resolved Hide resolved
srcpkgs/python3-poetry-core/template Outdated Show resolved Hide resolved
@kwshi
Copy link
Contributor Author

kwshi commented Apr 28, 2021

@eli-schwartz has pointed out on #30551 that python3-pep517 packages are currently using pip, which may exhibit undesirable behavior. Currently, in this PR I've configured the package (python3-poetry-core) to build itself using PEP517, but should I switch to making it use the sdist setup.py from the PyPI tarball instead?

@kwshi kwshi requested a review from ahesford April 28, 2021 19:22
@eli-schwartz
Copy link

Using the setup.py has consistent semantics in line with all other python ecosystem packages and additionally reduces the bootstrap graph a bit (maybe a lot, if void were to properly devendor pip/setuptools to use system dependencies).

And the pep517 build style is not commonly used -- in fact my understanding is it was added as a precautionary measure in case it became impossible to continue maintaining existing packages without it.

@kwshi
Copy link
Contributor Author

kwshi commented Apr 28, 2021

Alright! I have rewritten the template to build using python3-module instead of python3-pep517 now.

@kwshi
Copy link
Contributor Author

kwshi commented Apr 30, 2021

Since it looks like poetry-core might be pushing a new release soon, and there's a decent chance (fingers crossed!) it'll include tests in its sdist (see python-poetry/poetry-core#173), perhaps we'll wait a couple days & I can update this to the newest release before merging! :)

@kwshi kwshi marked this pull request as draft May 3, 2021 23:34
@ahesford ahesford closed this in 0f451e9 May 19, 2021
hazayan pushed a commit to hazayan/void-packages that referenced this pull request May 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants