New package: afetch-2.1.0 #30632
Closed
New package: afetch-2.1.0 #30632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astralchan
suggested changes
Jan 1, 2022
There was a problem hiding this comment.
Suggestions:
- Remove CFLAGS and LDFLAGS lines from template; upstream Makefile defined these.
- Remove pre_build and do_install; they do nothing here.
- Change
license=GPL-3.0-only. I couldn't find any indication the author intends to release under later version in README, comments, or otherwise. - Optional, but imo
"distfiles=${homepage}/archive/V${version}.tar.gz"looks neater, though some would disagree. - v2.2.0 is now released, update version and checksum.
|
@kawaiiamber unfortunately I'm not intrested anymore, feel free to pick it up if you care. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
Have the results of the proposed changes been tested?