Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binutils: remove dependency to binutils-doc #30678

Closed
wants to merge 1 commit into from

Conversation

ailiop-git
Copy link
Contributor

The binutils main package doesn't depend on the info files contained in
the documentation package. Remove it from being a dependency similar to
any other package whose documentation is split off into a subpackage.

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

The binutils main package doesn't depend on the info files contained in
the documentation package. Remove it from being a dependency similar to
any other package whose documentation is split off into a subpackage.
@ericonr
Copy link
Member

ericonr commented May 4, 2021

binutils is 26MB, binutils-doc is less than 1MB. IMO it makes more sense to remove the subpackage completely and fold it into binutils (add replaces="binutils-doc>=0" to binutils).

@ericonr
Copy link
Member

ericonr commented May 4, 2021

Ah, it isn't explained properly. It's split off because other packages depend on it: xbps-query -RX binutils-doc.

You could add a comment about it to the template instead, maybe.

@ailiop-git
Copy link
Contributor Author

So I agree with folding it into the main package, if we are to follow the manual guideline given that the size of the docs is the deciding factor (we do have other packages with tiny docs split off into a subpkg, e.g. 66, which probably need fixing).

I'm assuming that the original reason was so that the cross binutils can share the doc, but they certainly don't depend on it (so we probably better remove the depends from them). Both cross-arm-none-eabi-binutils and cross-or1k-none-elf-binutils rm the info files at the post_install phase so there should be no conflict.

What do you think?

@ericonr
Copy link
Member

ericonr commented May 4, 2021

The idea of the split is that it becomes necessary because we have many binutils packages which would otherwise conflict. But docs as a split package solve this. In that way, the fact that it's a subpackage could be considered an implementation detail (in order for all the packages to provide the complete deal, including docs) rather than something users should be worrying about, so I would go as far as to say there is nothing to change.

@ericonr
Copy link
Member

ericonr commented May 4, 2021

People consciously added binutils-doc to depends for the other packages, so I expect there to have been actual demand.

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label May 19, 2022
@github-actions github-actions bot closed this Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants