git-team: update to 1.6.0. #30936
Merged
git-team: update to 1.6.0. #30936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericonr
reviewed
May 17, 2021
Comment on lines
-17
to
-18
| mv ${DESTDIR}/usr/bin/prepare-commit-msg ${DESTDIR}/usr/bin/prepare-commit-msg-git-team | ||
| vinstall bash_completion/git-team.bash 0644 usr/share/bash-completion/completions git-team |
There was a problem hiding this comment.
Can you explain these removals in the commit message? (were the files removed? did something change how they work? ...)
There was a problem hiding this comment.
- The mv isn't necessary anymore, because prepare-commit-msg isn't shipped anymore as a seperate script, instead it get's created on demand in
~/.git-team/hooksby the main git-team binary. - The bash completion file indeed is gone, instead there is the
git-team completioncommand now which one can use in their bash startup scripts to source completion for git-team.
There was a problem hiding this comment.
Can you just copy your comment comment into the commit message, then?
There was a problem hiding this comment.
reworded a bit but done.
- dropped installation of /usr/bin/prepare-commit-message-git-team, it gets installed on-demand now by the main git-team binary into ~/.git-team/hooks. - dropped bash completion, one is supposed to source the output of `git-team completion` into their shell startup scripts now (only bash is supported for now).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
Have the results of the proposed changes been tested?