Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: yacy-1.924 #30939

Closed
wants to merge 361 commits into from
Closed

New package: yacy-1.924 #30939

wants to merge 361 commits into from

Conversation

jason1987d
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@folliehiyuki
Copy link
Contributor

The custom system account should be _yacy

@ericonr ericonr added the new-package This PR adds a new package label May 17, 2021
@folliehiyuki
Copy link
Contributor

Can you squash all the commits into 1?

@jason1987d
Copy link
Contributor Author

Can you squash all the commits into 1?

What's the best way to do this?

@folliehiyuki
Copy link
Contributor

I will go with git rebase --interactive HEAD~10 then drop all the relevant commits (except the 1st one).

Then git pull upstream master --rebase.

And finally adding your changes to the template (again), then git commit --amend, git push -f

@jason1987d jason1987d closed this May 24, 2021
@jason1987d jason1987d deleted the yacy branch May 24, 2021 21:45
@booniepepper
Copy link
Contributor

Just curious, but how are you doing rebases?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet