Komikku + python3-keyring update #30987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Sorry, I completely missed this. Will look into pulling it into master, if you can rebase it, that'd be great. |
re-introduce since python3-importlib_metadata needs it.
This package was dropped earlier as its functionality was added into Python 3.8 standard library. However, this package contains features that are not (yet) part of Python's standard library. Those features are needed by python3-keyring package. So, reintroduce this package. See: jaraco/keyring#499 (comment)
- update dependencies
reintroduce as Komikku needs it again.
As it is reintroduced.
It's already pulled in by python3-cloudscraper. Also sort depends for convenience.
|
np, rebased. I also reintroduced |
hazayan
pushed a commit
to hazayan/void-packages
that referenced
this pull request
Jun 25, 2021
python3-cloudscraper depends on it but Komikku itself doesn't. Also sort depends for convenience. Closes: void-linux#30987 [via git-merge-pr]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Komikku:
This version needs
python3-keyring>= 21.6.0python3-keyring:
update dependencies
python3-importlib_metadata:
This package was dropped earlier as its functionality was added into Python 3.8 standard library.
However, this package contains features that are not (yet) part of Python's standard library.
Those features are needed by
python3-keyringpackage. So, re-introduce this package.See: jaraco/keyring#499 (comment)
python3-zipp:
re-introduce since
python3-importlib_metadataneeds it.General
Have the results of the proposed changes been tested?