Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC]: scripts/lint-commits: report github noreply emails #31053

Closed
wants to merge 1 commit into from

Conversation

paper42
Copy link
Member

@paper42 paper42 commented May 21, 2021

ping @sgn

@Chocimier
Copy link
Member

What's the point of asking for mail, when know github account of commiter?

@ericonr
Copy link
Member

ericonr commented May 21, 2021

This is a big policy matter, because it means we won't accept contributions via GitHub UI anymore. Are we sure about it?

@paper42
Copy link
Member Author

paper42 commented May 21, 2021

I sometimes contact package maintainers by email when I want to let them know about something (that's not suitable for an issue and they are not on IRC). I didn't have to contact a maintainer who doesn't have their email address public yet.

Also, people who have a github noreply email address often make their pull requests from the Github UI. I think that by itself is fine, but there is a higher probability that these changes are not well tested. Adding an email address shouldn't be a big problem for people. Void already requires email addresses in the maintainer field in package templates.

This is just a lint, so exceptions can be made, but I think having this information can be valuable.

This is a big policy matter, because it means we won't accept contributions via GitHub UI anymore. Are we sure about it?

When people add a public email address to their account, they can use that address in the Github UI.

@paper42 paper42 changed the title scripts/lint-commits: report github noreply emails [RFC]: scripts/lint-commits: report github noreply emails May 21, 2021
common/scripts/lint-commits Outdated Show resolved Hide resolved
common/scripts/lint-commits Outdated Show resolved Hide resolved
@paper42
Copy link
Member Author

paper42 commented Apr 2, 2022

This proposal doesn't seem to have support among team members, closing.

@paper42 paper42 closed this Apr 2, 2022
@paper42 paper42 deleted the lint-commits-noreply branch April 8, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants