Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustup: install completions for Cargo. #31150

Closed
wants to merge 1 commit into from

Conversation

gbrlsnchs
Copy link
Contributor

@gbrlsnchs gbrlsnchs commented May 27, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr
Copy link
Member

ericonr commented May 27, 2021

This makes the rustup package conflict with cargo, which isn't ideal.

@gbrlsnchs
Copy link
Contributor Author

This makes the rustup package conflict with cargo, which isn't ideal.

Is there a useful use case where one installs both cargo and rustup?

@ericonr
Copy link
Member

ericonr commented May 27, 2021

There can be, I don't think we should make it impossible to install them together...

To be fair, I don't feel this as much because fish has built in completions already, but still.

@gbrlsnchs
Copy link
Contributor Author

There can be, I don't think we should make it impossible to install them together...

To be fair, I don't feel this as much because fish has built in completions already, but still.

I agree. The reason I opened this PR is because I switched from manually installed rustup to the one packaged by Void, and the first thing I noticed was my Cargo completion wasn't working anymore. What do you think is the best solution for this case? Should I keep my rustup template patched locally only? I wouldn't mind, really.

@ericonr
Copy link
Member

ericonr commented Jun 1, 2021

I'm really not sure... The final version of this PR, if merged, should also remove installation of these files from the cargo package, but I'm mostly against changing this. There isn't an ideal solution, I think.

@ericonr
Copy link
Member

ericonr commented Jun 12, 2021

Ok, I'm closing this for now.

@ericonr ericonr closed this Jun 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants