Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: drawio-desktop-14.6.13 #31195

Closed

Conversation

noarchwastaken
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr ericonr added the new-package This PR adds a new package label May 28, 2021
@noarchwastaken noarchwastaken force-pushed the drawio-desktop branch 3 times, most recently from 6a08270 to dd887a6 Compare May 28, 2021 20:59
@noarchwastaken
Copy link
Contributor Author

I'm not sure whether the desktop entry should be called draw.io or diagrams.net.

The former is still used everywhere internally, including the executable script and the desktop file in the "official" appimage, and the latter is the current "supposed" branding but is only used in places like the about page and the window title.

@Johnnynator
Copy link
Member

All these find and for loops make that template quite ugly to read imo. Maybe electron builder can be abused to provide a more usable directory structure.

Regarding naming an so, you could just take a look at the official '.deb' or '.rpm' and copy the naming from there.

@noarchwastaken
Copy link
Contributor Author

All these find and for loops make that template quite ugly to read imo.

Most of these are just to keep the destdir clean; The AUR package that I'm referencing from is pretty cursed in some places, I tweaked it significantly but kept the cleanup process.
I'm pretty sure everything will work fine without the cleanup; but the size of the produced package might be a tiny bit bigger.
Your opinion on removing that bit for extra readability?

Maybe electron builder can be abused to provide a more usable directory structure.

I had a peek at your Rocket.Chat-Desktop package, it seems like Rocket.Chat supports electron-builder OOTB so you can simply yarn run electron-builder ... to build it.
However draw.io doesn't seem to support it, so I might have to write an electron-builder.json and so on...

Regarding naming an so, you could just take a look at the official '.deb' or '.rpm' and copy the naming from there.

The official .deb and .rpm are pretty much just uncompressed appimage, installed in /opt. They still use drawio, so I think I'm fine here.

@noarchwastaken
Copy link
Contributor Author

@Johnnynator nvm, I just realized that drawio-desktop actually have electron-builder configs.

I have updated the template to use electron-builder, please have a look ;)

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label May 21, 2022
@github-actions github-actions bot closed this Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants