Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nnn: add desktop entry #31204

Merged
merged 1 commit into from May 31, 2021
Merged

nnn: add desktop entry #31204

merged 1 commit into from May 31, 2021

Conversation

anubhavkini
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@Duncaen
Copy link
Member

Duncaen commented May 29, 2021

This looks kinda wrong, it respects both PREFIX and DESTDIR, should probably just use make_install_target="install install-desktop" instead.

@anubhavkini
Copy link
Contributor Author

Yeah, I've changed it now.

@ericonr ericonr merged commit 5583fd6 into void-linux:master May 31, 2021
@anubhavkini anubhavkini deleted the nnn branch May 31, 2021 15:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anubhavkini @Duncaen @ericonr