Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New packages: mailnag-2.2.0, mailnag-goa-plugin-2.0.0 #31367

Merged
merged 2 commits into from Jun 14, 2021
Merged

New packages: mailnag-2.2.0, mailnag-goa-plugin-2.0.0 #31367

merged 2 commits into from Jun 14, 2021

Conversation

meator
Copy link
Contributor

@meator meator commented Jun 8, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Does it build and run successfully?

(Please choose at least one native build and, if supported, at least one cross build. More are better.)

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv7l
    • armv6l-musl

srcpkgs/mailnag/template Outdated Show resolved Hide resolved
srcpkgs/mailnag/template Outdated Show resolved Hide resolved
srcpkgs/mailnag/template Outdated Show resolved Hide resolved
srcpkgs/mailnag/template Outdated Show resolved Hide resolved
@Chocimier Chocimier added the new-package This PR adds a new package label Jun 8, 2021
@meator
Copy link
Contributor Author

meator commented Jun 8, 2021

@Chocimier, thank you for your advice, this is the first package that I have added here and also my first contribution to a public Github project. So I hope that this will be alright.

srcpkgs/mailnag/template Outdated Show resolved Hide resolved
@meator
Copy link
Contributor Author

meator commented Jun 12, 2021

I've just added some stylistic changes, the package should be now ready for merge.

@meator meator changed the title New package: mailnag-2.2.0 [WIP] New package: mailnag-2.2.0 Jun 12, 2021
@meator meator marked this pull request as draft June 12, 2021 15:29
@meator meator changed the title [WIP] New package: mailnag-2.2.0 New packages: mailnag-2.2.0, mailnag-goa-plugin-2.0.0 Jun 12, 2021
@meator meator marked this pull request as ready for review June 12, 2021 15:57
@Chocimier
Copy link
Member

Given it is gtk application, adding dependency on gnome-keyring may be better than leaving it failing with non-obvius error.
Function should go after variables, not in between.

@meator
Copy link
Contributor Author

meator commented Jun 12, 2021

I rebased my fork. Everything should be up to date now.

@meator
Copy link
Contributor Author

meator commented Jun 12, 2021

I had a little discussion about this in IRC. It's mentioned in README.voidlinux and I have created an issue on their github about this. And some people might get it from the error message so I think this is the best solution.

@meator
Copy link
Contributor Author

meator commented Jun 12, 2021

And I moved the function.

@meator
Copy link
Contributor Author

meator commented Jun 13, 2021

So what do you think about adding a libsecret client to dependencies?

@Chocimier
Copy link
Member

I think this is the best solution

ok

@Chocimier Chocimier merged commit d4c120f into void-linux:master Jun 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants