New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: please-0.4.1 #31430
Closed
Closed
New package: please-0.4.1 #31430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abenson
reviewed
Jun 11, 2021
abenson
reviewed
Jun 11, 2021
abenson
reviewed
Jun 11, 2021
abenson
reviewed
Jun 11, 2021
abenson
reviewed
Jun 11, 2021
On 2021-06-11 16:39-0700, Andrew Benson wrote:
+pkgname=pleaser
Why not just call it `please`?
@abenson, I'm happy for it to be named please here, which matches
upstream naming.
Thanks for reviewing the template so far, I believe I've made the other
corrections that you pointed out.
|
abenson
reviewed
Jun 12, 2021
abenson
reviewed
Jun 12, 2021
abenson
reviewed
Jun 12, 2021
+_binary=please
+pre_build() {
+ export CC_${RUST_BUILD//-/_}="${BUILD_CC}"
+}
+post_install() {
+ local manpage
@abenson, I've updated the template, thanks for looking again
|
Hello @abenson, are you happy to merge this now?
|
Hello @abenson, are you happy to merge this now? |
Thank you for your interest in Void Linux. After significant internal discussion your request for this package has been rejected due to generally duplicated functionality already present in Void's repos, and concerns related to the security critical nature of the software. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
Have the results of the proposed changes been tested?
This was previously raised in #27037 but has since been reviewed by the SUSE security team.