Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: gn-0.1915 #31447

Closed
wants to merge 1 commit into from
Closed

New package: gn-0.1915 #31447

wants to merge 1 commit into from

Conversation

whoizit
Copy link
Contributor

@whoizit whoizit commented Jun 13, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Required for Dart pkg building and other projects (chromium, electron)
https://repology.org/project/gn/versions

I'm not exactly sure about the choice of license, because it uses the word owner, that not used in BSD-3-Clause

@q66
Copy link
Contributor

q66 commented Jun 13, 2021

no point in packaging this, gn is not stable so different things require different versions

@ericonr
Copy link
Member

ericonr commented Jun 13, 2021

The GN readme recommends vendoring/using a git submodule for GN, so every project using it can track the necessary version by themselves. A system version wouldn't be very useful, and testing for updates would be painful.

@ericonr
Copy link
Member

ericonr commented Jun 13, 2021

If you need a GN to build dart, it could be called dart-gn or similar, but I don't think being a template has helped in simplifying the build or something of the sort, so just bootstrapping it inside the dart build makes more sense to me.

@whoizit whoizit closed this Jun 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants