-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3-dotenv: update to 0.18.0. #31470
Conversation
yes :) Do you have |
I assume you've tested docker-compose with this? |
I didn't use ci-skip anywhere. Will force push a commit and see if it triggers the builds. I have tested it. I use it on my machine for development. Here is a short example:
|
0bfd740
to
c2bf732
Compare
@ericonr So some of the tests are failing because the test suite is using |
If you can figure out a way to skip those tests, I think we can push the package with tests enabled (might be missing Otherwise, |
6a93ab3
to
ed2cfac
Compare
I have updated the template to skip tests that didn't work with xbps-src. For this, I have added a make_check_args="-k 'not test_cli'" But it would throw this error: So I ended up redefining the |
ed2cfac
to
a2a6ab7
Compare
Nevermind I ended up not using quotes inside |
Assuming it works, it seems 0.18.0 is out D: |
@ericonr I will update it to 0.18 in a bit. |
a2a6ab7
to
170dc45
Compare
170dc45
to
94cedf4
Compare
@ericonr Have tested the update and it works fine. Both as python module and cli. I have tested it with docker-compose as well and it works there too. The issues with some test cases failing in xbps-src still persist so I have left the |
General
Have the results of the proposed changes been tested?
Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
Notes
The only package that depends on this is
docker-compose
. I don't think it needs to be rebuilt since it's a python3 module. Am I correct?