New packages: interception-tools-0.6.7, caps2esc-0.3.2

[sbogomolov]

General

• This is a new package and it conforms to the quality requirements

Have the results of the proposed changes been tested?

• I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
• I generally don't use the affected packages but briefly tested this PR

[sbogomolov]

I've added README files as docs. It's better than nothing :)

[sbogomolov]

Is there something I have to do in order to get that workflow approval?

[sbogomolov]

This is my first contribution, so I have no idea how long it should take until the first reaction or until the workflow to run the CI gets approved. Are the re some steps I should take in order for this to happen?

[ericonr]

Pinging the PR is ok, or join us on IRC and mention it. We can't configure GH to auto-allow CI :/

New package PRs are usually quite low priority, unfortunately.

[sbogomolov]

Thanks, I'll try IRC channel next time :)

[sbogomolov]

@ericonr Thank you for reviewing this change. I have addressed all your comments in the last commit.

[sbogomolov]

I have checked the aarch64 cross compilation and it seems that the include directory is wrong.

FAILED: CMakeFiles/uinput.dir/uinput.cpp.o 
/builddir/.xbps-interception-tools/wrappers/aarch64-linux-gnu-c++  -I/usr/include/libevdev-1.0 -fstack-clash-protection -D_FORTIFY_SOURCE=2 -O2 -march=armv8-a   -I/usr/aarch64-linux-gnu/usr/include -Wall -Wextra -pedantic -std=c++11 -MD -MT CMakeFiles/uinput.dir/uinput.cpp.o -MF CMakeFiles/uinput.dir/uinput.cpp.o.d -o CMakeFiles/uinput.dir/uinput.cpp.o -c ../uinput.cpp
../uinput.cpp:15:10: fatal error: libevdev/libevdev-uinput.h: No such file or directory
   15 | #include <libevdev/libevdev-uinput.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

It uses -I/usr/include/libevdev-1.0 instead of -I/usr/aarch64-linux-gnu/usr/include/libevdev-1.0.

[ericonr]

Yeah, they don't know how to use cmake... https://gitlab.com/interception/linux/tools/-/blob/master/CMakeLists.txt#L9

[sbogomolov]

Yeah, saw that. I've submitted a MR: https://gitlab.com/interception/linux/tools/-/merge_requests/16.
For now I'll add a patch to work around this.

[sbogomolov]

Another merge request to replace __pid_t with pid_t: https://gitlab.com/interception/linux/tools/-/merge_requests/17.
This allows to build it with musl. I'll add a patch for that as well (until it gets merged and new version is released).

These two patches should fix all the builds. At lest "it works on my machine" (as in builds for all architectures) :)

[sbogomolov]

@ericonr it worked :) Is there anything else I should change in order for this to be merged?

[sbogomolov]

I've updated the license from GPL-3.0-or-later to GPL-3.0-only. Upstream does not mention which one it is, but dual-licensing should require explicit mentioning, so I'll go with the safer option.

[ericonr]

Ok, the packages look reasonable and I see why it can be useful (though note that with framebuffer, X and xkbcommon keymaps (for wayland) one should be able to implement what it does).

Since it required some patching, I'd prefer to wait for upstream to answer to your PRs so we can see how "packageable" it will end up being :)

[sbogomolov]

Sounds reasonable, let's wait.

Regarding the alternative solutions, I did not find any (for Wayland). What this achieves is that Caps lock key has two functions:

• ESC on tap
• Ctrl on press

There are multiple ways to achieve any one of those behaviours, but not both. Or at least I could not find them :)

[sbogomolov]

@ericonr Both PRs were accepted and new version 0.6.7 was tagged. In the last commit I have removed both patches and bumped the version.

[ericonr]

Great to hear the patches were upstreamed!

[sbogomolov]

@ericonr All your comments were addressed in the last push.

[sbogomolov]

@ericonr do you think this can be merged now?