New package: esptool-3.1 #31610
Closed
New package: esptool-3.1 #31610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Am I missing anything in the commits, or a procedure to let this PR progress? |
ericonr
reviewed
Jul 20, 2021
ericonr
reviewed
Aug 3, 2021
Comment on lines
+7
to
+8
| depends="python3-pyserial python3-ecdsa python3-pyaes | ||
| python3-bitstring python3-reedsolo" |
There was a problem hiding this comment.
Can you put this in same order as https://github.com/espressif/esptool/blob/master/setup.py#L128 ?
And I think it's missing cryptography explicitly?
Given https://github.com/espressif/esptool/blob/master/setup.py#L118, you probably need some additional checkdepends too.
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
Have the results of the proposed changes been tested?
Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
No hardware hackers on Void? Or did I miss the boat on a way better tool to program ESP's?
esptooldepends onpython3-reedsolo, I've bundled both new packages in this PR.I am doubting if I should strip the
.pyextension from the installed binaries, as the help output still references the binaries including the.pyextension.