Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qscintilla-qt5 update to 2.14.1, new package python3-pyqt5-qsci #31620

Merged
merged 2 commits into from Jul 25, 2023

Conversation

sgn
Copy link
Member

@sgn sgn commented Jun 23, 2021

@Nyx70 part of effort for QGis

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label May 23, 2022
@gabriel-russo
Copy link

What is missing to this PR to merge?

@github-actions github-actions bot removed the Stale label Jun 5, 2022
@github-actions
Copy link

github-actions bot commented Sep 3, 2022

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Sep 3, 2022
@sgn
Copy link
Member Author

sgn commented Sep 3, 2022 via email

@github-actions github-actions bot removed the Stale label Sep 4, 2022
@ar-jan
Copy link
Contributor

ar-jan commented Nov 6, 2022

I'm now running QGIS 3.28 using this. Would be great to have it committed so I can use it in PR for QGIS. Do you need any more specific testing?

@ar-jan ar-jan mentioned this pull request Jan 22, 2023
@ar-jan
Copy link
Contributor

ar-jan commented Jan 29, 2023

Compilation on ARM no longer works:

=> python3-pyqt5-qsci-2.12.1_1: running do_configure ...
Querying qmake about your Qt installation...
Checking to see if the Qsci bindings can be built...
sip-build: '/builddir/python3-pyqt5-qsci-2.12.1/Python/build/cfgtest_Qsci/./Qsci' didn't create any output
=> ERROR: python3-pyqt5-qsci-2.12.1_1: do_configure: 'sip-build --no-make ${_qt:+--qmake "$XBPS_WRAPPERDIR/sip-qmake"} --api-dir /usr/share/$_qt/qsci/api/python $configure_args --build-dir "$sip_builddir"' exited with 1
=> ERROR: in do_configure() at common/build-style/sip-build.sh:124

I am using this in #41812 so I'm hoping this can get in.

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Apr 30, 2023
@ar-jan
Copy link
Contributor

ar-jan commented Apr 30, 2023

Bump.

@github-actions github-actions bot removed the Stale label May 1, 2023
@ar-jan
Copy link
Contributor

ar-jan commented Jun 24, 2023

Hi @sgn, are you willing to take another look at this?

@sgn sgn force-pushed the qscintilla-qt5 branch 2 times, most recently from aed51c1 to fa69ca9 Compare June 24, 2023 16:54
@classabbyamp
Copy link
Member

updated to 2.14.1 and fixed cross (patch had the wrong package name in it)

@classabbyamp classabbyamp changed the title qscintilla-qt5 update to 2.12.1, new package python3-pyqt5-qsci qscintilla-qt5 update to 2.14.1, new package python3-pyqt5-qsci Jul 25, 2023
@classabbyamp
Copy link
Member

tested the non-python part with openscad and octave, works fine. @ar-jan can you rebase your qgis branch and test this?

@ar-jan
Copy link
Contributor

ar-jan commented Jul 25, 2023

Yup, I can confirm that QGIS (including PyQGIS) works with these versions.

@classabbyamp classabbyamp merged commit e4d8977 into void-linux:master Jul 25, 2023
8 checks passed
@sgn sgn deleted the qscintilla-qt5 branch August 23, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants