common/scripts: import xbps-cycles. #31631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably won't work as is, should run inside a void container. |
From https://github.com/ahesford/xbps-cycles, that is based on https://gist.github.com/Chocimier/de76441493ec7775c201dac0bb03ced5 . License is compatible with void-packages. Will be run in CI, so it should live in the same repository.
Should help in catching cyclic dependencies early. Rename lockthreads.yml to include all scheduled CI tasks.
|
Top patch is for sending mail on cycles detected. |
|
Changed to open informative issue rather than sending vague email. |
|
Ok, and it already implements a check to not open repeat issues ! ANything else we need? |
allows to modify deps and see if cycle is resolved
|
I think it's ready. @ahesford ? |
|
Looks good to me |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://github.com/ahesford/xbps-cycles, license is compatible with
void-packages. Will be run in CI, so it should live in the same
repository.
General
Have the results of the proposed changes been tested?