perl: update to 5.34

[dkwo]

This is my attempt: perl builds and tests ok on x86_64.
Had to remove a part of a patch, and add a variable to skip certain tests.

[dkwo]

I have a question: xbps-query -RX perl lists all packages that depend on perl.
Those include e.g. texlive2020-bin, which was not revbumped in #25929 : so what is the criterion for ignoring some?
Should we revbump recursively, namely revbump the full tree starting from perl?
Should we revbump packages that (host)makedepend on perl, as well as those with build_style=perl-ModuleBuild?

[dkwo]

Ok, so right now I would revbump all packages in:

xbps-query -RX perl | xargs -n1 xbps-uhelper getpkgname
grep -rnwl 'srcpkgs/' -e 'build_style=perl-module'
grep -rnwl 'srcpkgs/' -e 'build_style=perl-ModuleBuild'
grep -rnwl 'srcpkgs/' -e 'makedepends.*perl'
grep -rnwl 'srcpkgs/' -e 'hostmakedepends.*perl'

Open to suggestions.

[dkwo]

do not rebuild for the moment: texlive*, thunderbird, chromium, firefox, gcc, cross-*, qt5/6 stuff.

[ericonr]

@dkwo things that depend only on perl as hostmakedepends should usually not be rebuilt.

[dkwo]

Had to update perl-Business-ISBN-Data and remove its patch.

[dkwo]

@ericonr Thanks, I'm now testing that everything builds.

[Chocimier]

Perl modules in general and packages depending on perl don't need to be rebuild either. 5.32 rebuild was big because of noarch, but 5.30 only had packages requiring perl versioned soname, you can get list with xbps-query -p shlib-requires -Rs libperl.so.5.32

[dkwo]

@Chocimier thanks, now it looks better.

I built everything on x86_64 and checked perl.
Only package I'm unsure about is perl-Crypt-Rijndael: to update it, had to remove a patch.
I may revbump a few more to pass biber tests as well, other than that it should be ready: these tests complain that lib/Params/Validate/XS.c: loadable library and perl binaries are mismatched (got handshake key 0xed00080, needed 0xeb00080)

[dkwo]

I fixed all lint errors, except for

$ xlint perl-Barcode-ZBar
/tmp/build/void-packages/srcpkgs/perl-Barcode-ZBar/template:5: wrksrc should be a top-level directory

How should I deal with it?

[sgn]

I fixed all lint errors, except for

$ xlint perl-Barcode-ZBar
/tmp/build/void-packages/srcpkgs/perl-Barcode-ZBar/template:5: wrksrc should be a top-level directory

How should I deal with it?

#31844

[leahneukirchen]

% gg shlib_requires.*perl
HEAD:liboping/template: shlib_requires="libperl.so.5.32"
HEAD:perl-Lchown/template:shlib_requires=libperl.so.5.32
HEAD:rrdtool/template:  shlib_requires="libperl.so.5.32"

you need to bump these references too.

[dkwo]

@leahneukirchen Thanks.

Any idea how to fix this perl test failure?

Test Summary Report
-------------------
../lib/ExtUtils/t/Embed.t                                          (Wstat: 0 Tests: 6 Failed: 1)
  Failed test:  10
  Parse errors: Tests out of sequence.  Found (10) but expected (6)
                Bad plan.  You planned 10 tests but ran 6.
Files=2676, Tests=1191415, 574 wallclock secs (98.26 usr 19.10 sys + 635.60 cusr 69.57 csys = 822.53 CPU)
Result: FAIL

I can imagine how to fix musl locale, as e.g. in alpine..

[leahneukirchen]

I don't know really. The math bug also appeared in prior release.

IMO we can ignore it...

[dkwo]

@leahneukirchen I think it is ready, so you can go ahead.

To summarise, for future reference: these fail some tests (some of them probably failed before the update):

gnumeric
perl-Fuse
perl-Gtk2
perl-Image-Sane
perl-Linux-Inotify2
perl-OpenGL
perl-Search-Xapian
perl-Unix-Mknod
perl-pcsc
postgresql12
postgresql13
rrdtool
subversion

The perl itself passes all tests on x86_64, so at worst it could fail locale on x86_64-musl and math on i686.

As for srcpkgs/biber/template, I left it with this PR, even though it was not required.
Will come back to its test failures maybe later.

As a final note, it would be nice to have a mechanism to force CI to first build all commits, and only do checks later, not sure if it's possible though.

[leahneukirchen]

I agree, but that's how the CI currently is.

[leahneukirchen]

merged with git-merge-pr, as the UI doesn't like rebasing big PR.

[dkwo]

Just for future reference: it seems also

apparmor
ImageMagick
ImageMagick6
perl-Alien
perl-DateTime-Locale
perl-File-ShareDir
perl-HTTP-Message
perl-List-MoreUtils
perl-List-SomeUtils
perl-List-UtilsBy
perl-Params-Validate
perl-Specio
perl-Text-BibTeX

(all passing checks, except the last one) could use a rebuild.