Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xdebug: update to 3.0.4, remove php-pear in favour of pear (we bootstrapping now folks) #31679

Closed
wants to merge 3 commits into from
Closed

xdebug: update to 3.0.4, remove php-pear in favour of pear (we bootstrapping now folks) #31679

wants to merge 3 commits into from

Conversation

the-eater
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@the-eater
Copy link
Contributor Author

As a note, I am assigning myself as maintainer of php and xdebug I've been the major force doing the bigger upgrades for those the last few years, and the original maintainers haven't touched it in 4 years and considering my open RFC it would make sense. I am not expecting anybody to have an issue with this.

@the-eater the-eater mentioned this pull request Jun 27, 2021
Closed
3 tasks
ericonr
ericonr reviewed Jul 4, 2021
View reviewed changes
srcpkgs/pear/template
depends="php"
conf_files="/etc/php/pear.conf"
short_desc="PEAR - PHP Extension and Application Repository"
maintainer="eater <=@eater.me>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, = is legal? :o

srcpkgs/pear/template
Comment on lines +65 to +67
# PEAR would normally replace these, but we're pearless at this point
vsed -i 's:\(.\)@data_dir@/PHP_Archive/:__DIR__ . \1/../:;s:@API-VER@:1.1.0:' \
go-pear-tarballs/src/PHP/Archive/Creator.php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A peerless substitution :D

srcpkgs/php/template
revision=3
revision=4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add an install.msg for php-pear saying that Pear has been removed? And make php-pear a dumy transitional package for now.

We can't make it depend on pear due to cyclic deps, and pear can't have a php-pear subpackage without a huge list of reverts.

@ericonr
Copy link
Member

ericonr commented Jul 4, 2021

And I think in the commit message for pear you should explain why it's needed as a separate package too :)

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label May 24, 2022
@github-actions github-actions bot closed this Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericonr ericonr ericonr left review comments

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@the-eater @ericonr