Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instaloader: update to 4.7.4. #31800

Merged
merged 1 commit into from Jul 11, 2021
Merged

Conversation

mobinmob
Copy link
Contributor

@mobinmob mobinmob commented Jul 4, 2021

Also:

  • expand the $pkgname in distfiles
  • remove license file and the special handling from the template
    (now the tarball contains a license file).

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to only depend on python3-requests now? https://github.com/instaloader/instaloader/blob/master/setup.py

@fosslinux

@fosslinux
Copy link
Contributor

@ericonr is correct but other than that looks good.

Also:
- expand the $pkgname in distfiles
- remove license file and the special handling from the template
(now the tarball contains a license file).
-remove unneeded deps.
@mobinmob
Copy link
Contributor Author

@ericonr I removed the uneeded packages from depends.

@ericonr ericonr merged commit ad8525e into void-linux:master Jul 11, 2021
@mobinmob mobinmob deleted the instaloader branch July 12, 2021 20:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants