Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc: allow building with current Sphinx #31898

Merged
merged 1 commit into from Jul 20, 2021
Merged

Conversation

chexum
Copy link
Contributor

@chexum chexum commented Jul 10, 2021

./srcpkg build ghc fails with current tools:

"inplace/bin/ghc-stage1" [...] /build/cbits/longlong.p_o
Running Sphinx v4.0.2

Configuration error:
There is a syntax error in your configuration file: (unicode error) 'unicodeescape' codec can't decode bytes in position 1-2: truncated \uXXXX escape (conf.py, line 87)

...
make: *** [Makefile:128: all] Error 2

According to https://gitlab.haskell.org/ghc/ghc/-/issues/19962

This fix is to use raw strings, as already done in master:
https://gitlab.haskell.org/ghc/ghc/-/blob/master/docs/users_guide/conf.py#L96

Sanitized from commit (only small parts apply)
https://gitlab.haskell.org/ghc/ghc/-/commit/83407ffc7acc00cc025b9f6ed063add9ab9f9bcc

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

[skip CI] build might take over 3 hours with a single CPU - local build/pkg tested

Does it build and run successfully?

(Please choose at least one native build and, if supported, at least one cross build. More are better.)

  • I built this PR locally for my native architecture, (x86_64)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv7l
    • armv6l-musl

@chexum
Copy link
Contributor Author

chexum commented Jul 11, 2021

By the way, it seems the build checks are failing because there is no check target:

2021-07-10T22:39:46.1203634Z ===--- building final phase
2021-07-10T22:39:46.1204570Z make --no-print-directory -f ghc.mk phase=final check
2021-07-10T22:39:49.0161381Z make[1]: *** No rule to make target 'check'. Stop.
2021-07-10T22:39:49.0186932Z make: *** [Makefile:128: check] Error 2
2021-07-10T22:39:49.0191464Z => ERROR: ghc-8.8.4_3: do_check: '${make_cmd} ${make_check_args} ${make_check_target}' exited with 2
2021-07-10T22:39:49.0193972Z => ERROR: in do_check() at common/build-style/gnu-configure.sh:33
2021-07-10T22:39:49.0462777Z ##[error]Process completed with exit code 1.

srcpkgs/ghc/template Outdated Show resolved Hide resolved
./srcpkg build ghc fails with current tools:

"inplace/bin/ghc-stage1" [...] /build/cbits/longlong.p_o
Running Sphinx v4.0.2

Configuration error:
There is a syntax error in your configuration file: (unicode error) 'unicodeescape' codec can't decode bytes in position 1-2: truncated \uXXXX escape (conf.py, line 87)

...
make: *** [Makefile:128: all] Error 2

According to https://gitlab.haskell.org/ghc/ghc/-/issues/19962

>> This fix is to use raw strings, as already done in master:
>> https://gitlab.haskell.org/ghc/ghc/-/blob/master/docs/users_guide/conf.py#L96

Sanitized from commit (only small parts apply)
https://gitlab.haskell.org/ghc/ghc/-/commit/83407ffc7acc00cc025b9f6ed063add9ab9f9bcc
@ericonr
Copy link
Member

ericonr commented Jul 20, 2021

Nice find, thanks!

@ericonr ericonr merged commit c74ff7e into void-linux:master Jul 20, 2021
@chexum chexum deleted the ghc-884 branch July 22, 2021 18:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants