j4-dmenu-desktop: add support for checks

[meator]

The current version of tests errors out when /usr/share/applications does not exist. See enkore/j4-dmenu-desktop#123

General

• This is a new package and it conforms to the quality requirements

Have the results of the proposed changes been tested?

• I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
• I generally don't use the affected packages but briefly tested this PR

Does it build and run successfully?

(Please choose at least one native build and, if supported, at least one cross build. More are better.)

• I built this PR locally for my native architecture, (x86_64-glibc)
• I built this PR locally for these architectures (if supported. mark crossbuilds):
  • x86_64-musl
  • aarch64-musl
  • armv7l
  • armv6l-musl

[ericonr]

Alternatively, we could add a package with files under /usr/share/applications to checkdepends, so it's installed when the test suite runs. What do you think?

[meator]

What do you mean by that?

[ericonr]

*with files

If it needs /usr/share/applications to exist, having something like xterm installed should be enough for the test suite to work...

[meator]

It doesn't actually need any .desktop files in /usr/share/applications, it just needs the folder. Adding some packages with desktop files to checkdepends is not really necessary. Another solution would be to mkdir -p /usr/share/applications in pre_check(). What do you think?

[ericonr]

I dislike mkdir here because we shouldn't touch the masterdir outside builddir and destdir. Using a package is preferred (add a comment on top of the checkdepends line, though.

[meator]

Ok. I have removed the patch.

[ericonr]

Great, thanks!