Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: kamoso-21.04.3_1 #31964

Merged
merged 1 commit into from Jul 26, 2021
Merged

New package: kamoso-21.04.3_1 #31964

merged 1 commit into from Jul 26, 2021

Conversation

hervyqa
Copy link
Contributor

@hervyqa hervyqa commented Jul 14, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Does it build and run successfully?

(Please choose at least one native build and, if supported, at least one cross build. More are better.)

  • I built this PR locally for my native architecture, (x86_64)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv7l
    • armv6l-musl

Screenshot_20210714_230801

@hervyqa hervyqa marked this pull request as draft July 14, 2021 16:14
@hervyqa hervyqa marked this pull request as ready for review July 14, 2021 16:37
@hervyqa
Copy link
Contributor Author

hervyqa commented Jul 14, 2021 •
edited

hi @ericonr @Johnnynator any idea?

https://download.kde.org/stable/release-service/21.04.3/src/kamoso-21.04.3.tar.xz: Connection timed out
=> ERROR: kamoso-21.04.3_1: failed to fetch kamoso-21.04.3.tar.xz.
Error: Process completed with exit code 1.

@hervyqa hervyqa mentioned this pull request Jul 14, 2021
Closed
Chocimier
Chocimier reviewed Jul 14, 2021
View reviewed changes
Copy link
Member

@Chocimier Chocimier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea?

Network is unreliable universally. Please build locally or rebase and push again.

srcpkgs/kamoso/template Outdated
version=21.04.3
revision=1
build_style=cmake
configure_args="-DBUILD_TESTING=OFF"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to run tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I try to fix. configure_args="-DBUILD_TESTING=OFF" i deleted it

srcpkgs/kamoso/template
revision=1
build_style=cmake
configure_args="-DBUILD_TESTING=OFF"
hostmakedepends="
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add qt5-host-tools kcoreaddons kconfig for cross build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added qt5-host-tools kcoreaddons kconfig

srcpkgs/kamoso/template Outdated
kconfig kconfigwidgets kcompletion kio ksolid knotifyconfig gst-plugins-good1
gst-plugins-bad1 phonon-qt5 qt5-graphicaleffects qt5-quickcontrols kirigami2
purpose"
checkdepends="$depends"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makedepends pull needed packages, please remove checkdepends=

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have deleted checkdepends="$depends"

srcpkgs/kamoso/template Outdated
kirigami2-devel knotifyconfig-devel purpose-devel qt5-multimedia-devel
qt5-quickcontrols2-devel"
depends="
kconfig kconfigwidgets kcompletion kio ksolid knotifyconfig gst-plugins-good1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kio, kconfig are autodetected, please remove.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have deleted kconfig kio

@Johnnynator
Copy link
Member

The commit message should be New package: kamoso-21.04.3_1

@hervyqa hervyqa changed the title New package: kamoso New package: kamoso-21.04.3_1 Jul 15, 2021
@hervyqa
Copy link
Contributor Author

hervyqa commented Jul 15, 2021 •
edited

The commit message should be New package: kamoso-21.04.3_1

done. New package: kamoso-21.04.3_1
thanks @Johnnynator. is there anything else that needs to be fixed?

@ericonr ericonr added the new-package This PR adds a new package label Jul 17, 2021
@Johnnynator Johnnynator merged commit f64aab3 into void-linux:master Jul 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2021
@hervyqa hervyqa deleted the kamoso-21.04.3 branch April 21, 2022 23:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Chocimier Chocimier Chocimier left review comments

Assignees
No one assigned
Labels
new-package This PR adds a new package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hervyqa @Johnnynator @Chocimier @ericonr