Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbound: add logging service #31992

Closed
wants to merge 1 commit into from

Conversation

TinfoilSubmarine
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr
Copy link
Member

ericonr commented Jul 17, 2021

@leahneukirchen LGTM

@leahneukirchen
Copy link
Member

no -t unbound?

@leahneukirchen
Copy link
Member

ah it autodetects that, fine.

@leahneukirchen
Copy link
Member

But log/supervise is missing, no?

@TinfoilSubmarine
Copy link
Contributor Author

That's automatically created by sv at runtime. I don't think it's supposed to be included in the package.

@TinfoilSubmarine
Copy link
Contributor Author

If you're trying to install and run this on your machine with unbound already installed and service enabled, you'll have to manually enable the log service, or just unlink and relink to /var/service/unbound

@Duncaen
Copy link
Member

Duncaen commented Jul 17, 2021

That's automatically created by sv at runtime. I don't think it's supposed to be included in the package.

No runsv creates the directory, not the symlink. It would just create a directory in the service directory if the symlink is missing.
vsv in xbps-src should create both supervise symlinks, but for some reason it does not do in the CI run.
https://github.com/void-linux/void-packages/runs/3082099002#step:9:67

@ericonr
Copy link
Member

ericonr commented Jul 20, 2021

So, is this actually necessary? I get unbound information just fine in svlogtail output without a log service...

@TinfoilSubmarine
Copy link
Contributor Author

TinfoilSubmarine commented Jul 20, 2021

Huh, you're right. I think I got confused when I was trying to enable logging within unbound because I copied a config from somewhere which didn't have the use-syslog: true directive. I'll close then, thanks for the tip.

As an aside, the issue about log/supervise missing may be related to log/run being a symlink to /usr/bin/vlogger since I checked several other services in void-packages using this symlink (bluez, dhcp, caddy) and none of them have log/supervise either. Not sure if this is intended behavior or not...

@ericonr
Copy link
Member

ericonr commented Jul 20, 2021

Not sure if this is intended behavior or not...

I don't think so. Can you open an issue so we can remember to try and fix it?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants