Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acpi_call-dkms: update to 1.2.1 and patch for kernel 5.13 #32022

Merged
merged 1 commit into from Jul 23, 2021

Conversation

dkwo
Copy link
Contributor

@dkwo dkwo commented Jul 17, 2021

I've tried to update as suggested #31968 , but when I install it fails to add the module

[*] Configuring unpacked packages
acpi_call-dkms-1.2.1_1: configuring ...
Failed to add DKMS module: 'acpi_call-1.2.1'...
acpi_call-dkms-1.2.1_1: updated successfully.

What should be changed?
Thanks.

@ericonr
Copy link
Member

ericonr commented Jul 17, 2021

Remove the redirection to /dev/null in /usr/libexec/xbps-triggers/dkms:

		$DKMS add -m "$1" -v "$2" >/dev/null 2>&1

Then install again to see why it fails.

@dkwo
Copy link
Contributor Author

dkwo commented Jul 18, 2021

Here's more data:

[*] Configuring unpacked packages
acpi_call-dkms-1.2.1_1: configuring ...
cat: VERSION: No such file or directory
dkms.conf: Error! No 'PACKAGE_VERSION' directive specified.
Error! Bad conf file.
File: /usr/src/acpi_call-1.2.1/dkms.conf
does not represent a valid dkms.conf file.
Failed to add DKMS module: 'acpi_call-1.2.1'...
acpi_call-dkms-1.2.1_1: updated successfully.

@dkwo
Copy link
Contributor Author

dkwo commented Jul 18, 2021

Should I just put a dkms.conf file by hand in /files with 1.2.1 instead of VERSION, or is there a smarter way?

@dkwo dkwo force-pushed the acpi branch 3 times, most recently from c2a4ddd to 0e6c07e Compare July 18, 2021 10:48
@dkwo
Copy link
Contributor Author

dkwo commented Jul 18, 2021

This works for me, but as I said I'm open to smarter solutions :)

I guess failure is related to less, as it builds fine here..

@ericonr
Copy link
Member

ericonr commented Jul 18, 2021

Use nix-community/acpi_call#17 instead of vendoring in the file.

@dkwo
Copy link
Contributor Author

dkwo commented Jul 19, 2021

Thanks. Does it look better now?

@ericonr
Copy link
Member

ericonr commented Jul 19, 2021

It does, thanks! We can merge once things are back to normal.

@ericonr ericonr merged commit d11afb4 into void-linux:master Jul 23, 2021
@dkwo dkwo deleted the acpi branch July 24, 2021 07:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants