Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jdupes 1200 #32048

Merged
merged 2 commits into from Jul 19, 2021
Merged

Jdupes 1200 #32048

merged 2 commits into from Jul 19, 2021

Conversation

chexum
Copy link
Contributor

@chexum chexum commented Jul 19, 2021

Despite the flag ENABLE_BTRFS is enabled for make, this seems to be mishandled by the way the Makefile builds the CFLAGS, so the functionality does not get included.

(It does not depend on any BTRFS headers, libraries, or ioctls, only if the appropriate flag is given on run)

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Does it build and run successfully?

(Please choose at least one native build and, if supported, at least one cross build. More are better.)

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-glibc
    • armv7l
    • armv6l-musl

CFLAGS set from the command line overrides
the logic to enable the dedup functionality
@leahneukirchen leahneukirchen merged commit 93ea7ee into void-linux:master Jul 19, 2021
@chexum chexum deleted the jdupes-1200 branch July 22, 2021 18:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants