Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework linux and linux-lts meta packages, also update linux-lts #32109

Merged
merged 3 commits into from
Aug 4, 2021

Conversation

ericonr
Copy link
Member

@ericonr ericonr commented Jul 21, 2021

Our dances for installing a given kernel version but still having firmware and dracut are error prone and unnecessary. This PR aims to solve that.

If we want to split the dracut dependency for greater initramfs flexibility, we can discuss that here too.

@ericonr
Copy link
Member Author

ericonr commented Jul 21, 2021

@void-linux/pkg-committers

@ahesford
Copy link
Member

I like this. We could make an initramfs virtual in place of dracut, but I don't really know wheter it's better to make the initramfs kernel hooks for every generator aware of /etc/default/initramfs-regenerate or to make a centralized kernel hook that is aware of every possible initramfs generator.

@ericonr
Copy link
Member Author

ericonr commented Jul 21, 2021

I worry about the virtual option because of how XBPS chooses to install virtuals. For example, when booster is merged, it might be installed in dracut's place.

A common hook, otoh, sounds great to me. I much prefer it over duplicating logic across hooks for each generator.

@ahesford
Copy link
Member

Yeah, I know a virtual is problematic, but we don't really have the machinery for alternate packages with a specific default.

Before, the issue with a central hook was where to put it. Putting the hook (post-install and post-remove) in your new linux-base makes perfect sense. We can keep the hard dracut dependency in linux-base for now, and people who want to use an alternative can install whatever they want, set /etc/default/initramfs-regenerate as appropriate, and ignorepkg if they really care about removing dracut.

@ericonr
Copy link
Member Author

ericonr commented Jul 22, 2021

As mentioned on IRC, having the common hook in linux-base would be bad for users who don't have that package. A cleaner fix is including the hook directly in xbps-triggers.

Base package to be used as dependency for linux and linux-lts. This way
they can share the same code and users who want to stick with a given
kernel version can just install that one and linux-base instead of
needing the linux or linux-lts meta and ignorepkg dances.
Also move to using linux-base.
Also move to using linux-base and xlint.
@ericonr ericonr merged commit 97d84cb into void-linux:master Aug 4, 2021
@ericonr ericonr deleted the base branch August 4, 2021 14:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants