Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trash-cli: update to 0.21.7.24. #32178

Closed
wants to merge 1 commit into from

Conversation

TeddyDD
Copy link
Contributor

@TeddyDD TeddyDD commented Jul 24, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr
Copy link
Member

ericonr commented Jul 26, 2021

Some tests seem to be expecting failures due to permissions, which won't happen in our CI container. Any chance we could skip those specifically?

@TeddyDD
Copy link
Contributor Author

TeddyDD commented Jul 27, 2021

I could patch decorators for failing tests

@pytest.mark.skip(reason="fails in CI")

or we could disable check altogether.

@paper42
Copy link
Member

paper42 commented Jul 27, 2021

It is possible to deselect failing tests with make_check_args="--deselect="tests/test_files.py" or mark tests broken in CI.

@TeddyDD TeddyDD force-pushed the update-trash-cli branch 3 times, most recently from 0881fb1 to 6168545 Compare July 30, 2021 17:25
srcpkgs/trash-cli/template Outdated Show resolved Hide resolved
@tibequadorian
Copy link
Contributor

New version: 0.21.10.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants