New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fail2ban: update to version 0.11.2 #32289
Conversation
@abenson, I'm tagging you as agreed on IRC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally, please remember to squash your commits into a single one :)
conf_files=" | ||
/etc/fail2ban/fail2ban.conf | ||
/etc/fail2ban/jail.conf | ||
/etc/fail2ban/action.d/*.conf | ||
/etc/fail2ban/filter.d/*.conf" | ||
make_dirs="/var/lib/fail2ban 0700 root root" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain in your commit message why this is now necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if it is. In current version this directory is not created so the first run will fail, because it can't create default database /var/lib/fail2ban/fail2ban.sqlite3
. I've added this as a convenience, but maybe previous maintainer of this package did it on purpose? Please advise should I add it or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do leave it in, then. Just mention that this makes first startup work out of the box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did it in #32303, this one I had to close because of my stupidity.
I've messed up too much on git part, sorry. I will close this PR and create new one. |
General
Have the results of the proposed changes been tested?