Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail2ban: update to version 0.11.2 #32289

Closed
wants to merge 3 commits into from
Closed

fail2ban: update to version 0.11.2 #32289

wants to merge 3 commits into from

Conversation

ftpd
Copy link
Contributor

@ftpd ftpd commented Aug 1, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ftpd
Copy link
Contributor Author

ftpd commented Aug 1, 2021

@abenson, I'm tagging you as agreed on IRC.

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, please remember to squash your commits into a single one :)

srcpkgs/fail2ban/template Outdated Show resolved Hide resolved
srcpkgs/fail2ban/template Outdated Show resolved Hide resolved
srcpkgs/fail2ban/template Outdated Show resolved Hide resolved
conf_files="
/etc/fail2ban/fail2ban.conf
/etc/fail2ban/jail.conf
/etc/fail2ban/action.d/*.conf
/etc/fail2ban/filter.d/*.conf"
make_dirs="/var/lib/fail2ban 0700 root root"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain in your commit message why this is now necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it is. In current version this directory is not created so the first run will fail, because it can't create default database /var/lib/fail2ban/fail2ban.sqlite3. I've added this as a convenience, but maybe previous maintainer of this package did it on purpose? Please advise should I add it or not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do leave it in, then. Just mention that this makes first startup work out of the box.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it in #32303, this one I had to close because of my stupidity.

@ftpd
Copy link
Contributor Author

ftpd commented Aug 3, 2021

I've messed up too much on git part, sorry. I will close this PR and create new one.

@ftpd ftpd closed this Aug 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants