Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node_exporter: Send output to syslog. #32348

Merged
merged 1 commit into from Sep 4, 2021
Merged

node_exporter: Send output to syslog. #32348

merged 1 commit into from Sep 4, 2021

Conversation

raindev
Copy link
Contributor

@raindev raindev commented Aug 5, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Does it build and run successfully?

(Please choose at least one native build and, if supported, at least one cross build. More are better.)

  • I built this PR locally for my native architecture, (x86_64, GNU libc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv7l
    • armv6l-musl

@raindev
Copy link
Contributor Author

raindev commented Aug 21, 2021

Is anything else needed to get the changes merged?

@Duncaen
Copy link
Member

Duncaen commented Aug 21, 2021

logger(1) is bad as it just sends logs into the void if the first time it tries to connect to the syslog socket fails. This should use vlogger(1).

@raindev
Copy link
Contributor Author

raindev commented Aug 21, 2021

Thanks for the feedback Duncan. Have I missed the preference for vlogger over logger being documented somewhere?

This is consistent with the way the logs of Prometheus itself are
treated.
@raindev
Copy link
Contributor Author

raindev commented Sep 3, 2021

Just wanted to follow up on getting the changes in.

@Duncaen Duncaen merged commit 36eb20b into void-linux:master Sep 4, 2021
@raindev
Copy link
Contributor Author

raindev commented Sep 5, 2021

Thank you Duncan!

@raindev raindev deleted the node_exporter-syslog branch September 5, 2021 07:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants