Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: k3d-4.4.7 #32349

Closed
wants to merge 1 commit into from
Closed

Conversation

klardotsh
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

I'm not a master of k3d by any means - I'm using it as a cheap playground to test out Tilt at work (which I might also package today). That said, I successfully created a simple cluster with k3d cluster create myclusternamehere using this package, so it seems alright.

@ericonr ericonr added the new-package This PR adds a new package label Aug 5, 2021
# to pull. incorrect strings here result in cluster creation
# failures+rollbacks.
go_ldflags="-X github.com/rancher/k3d/v4/version.Version=v${version}"
depends="docker"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it work with podman?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it will possibly arrive, I'd rather this not depend on docker.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell in the thread, this isn't being actively worked on, there's no ETA of when or if it may ever get worked on, and for that matter, got punted from a milestone to generic "backlog".

It looks safe to assume that at least for the near term (I'd guess at least 6mo), this is a Docker-only tool, and thus should depend on docker.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly I want to keep flexibility. We shouldn't have this tool be responsible for bringing in docker to people's system, otherwise if anything changes we'll have to figure out a fix, since docker will become an orphan package (in some situations).

@klardotsh
Copy link
Contributor Author

k3d wound up not working for what I needed, and I moved over to kind for running Kubernetes in a Docker world. I'm open to still submitting this package (with docker removed as a dependency) if you'd like, or I'm happy to close the PR - whatever you think is best for a package I don't personally use anymore.

@ericonr
Copy link
Member

ericonr commented Aug 26, 2021

Since no one's else expressed interest, and maintaining a package you don't use can be tiring and harder than it needs to be, i think it's ok to close this.

@klardotsh
Copy link
Contributor Author

Works for me. Thanks for the feedback on this regardless!

@klardotsh klardotsh closed this Aug 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants