Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

herbstluftwm: update to 0.9.3 #32365

Merged
merged 1 commit into from
Aug 7, 2021
Merged

herbstluftwm: update to 0.9.3 #32365

merged 1 commit into from
Aug 7, 2021

Conversation

xaverh
Copy link
Contributor

@xaverh xaverh commented Aug 6, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

The new dependency to libXrender-devel is mentioned in upstream's changelog.

@paper42
Copy link
Member

paper42 commented Aug 6, 2021

Hi, could you remove the "Merge branch" commit from this PR? The command to rebase on top of void's master (which should remove the merge commit) is git pull --rebase upstream master

@xaverh
Copy link
Contributor Author

xaverh commented Aug 6, 2021

Thank you for your help. I hope, everything is in the right format now.

Copy link
Member

@paper42 paper42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your PR is great now, but when we are here, let's fix some more small cosmetic issues

srcpkgs/herbstluftwm/template Outdated Show resolved Hide resolved
srcpkgs/herbstluftwm/template Outdated Show resolved Hide resolved
srcpkgs/herbstluftwm/template Outdated Show resolved Hide resolved
small cosmetic issues
@xaverh xaverh requested a review from paper42 August 7, 2021 17:38
Copy link
Member

@paper42 paper42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's perfect, thanks for contributing!

@paper42 paper42 merged commit 29f2c1b into void-linux:master Aug 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants