New package: x-unikey-1.0.4

[linhvng]

General

• This is a new package and it conforms to the quality requirements

Have the results of the proposed changes been tested?

• I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
• I generally don't use the affected packages but briefly tested this PR

[linhvng]

The patches follow what FreeBSD maintainer did to compile the package in FreeBSD. Here is the link to this package on FreeBSD: https://cgit.freebsd.org/ports/tree/vietnamese/x-unikey

I currently use it on my x86_64-glibc laptop 😃

[sgn]

-g -O2 is set by xbps-src, I'll add a patch for musl, too.

[sgn]

Most of them are GPL-2.0-or-later, some files are licensed under MIT.

[linhvng]

sorry, it's my first time adding a package and tracking down the license 😅 thought it was GPL2 because of the COPYING file... what license should i change it to?

[linhvng]

• remove -g -O2 from CFLAGS and CXXFLAGS
• update license to GPL-2.0-or-later

[sgn]

I've fixed the build for musl libc, however, it's hung when typing.

Anyway, just out of curiosity, have you tried another input framework?
I'm not really sure if it's worth to include this package for 1 user. :-p

[linhvng]

I've fixed the build for musl libc, however, it's hung when typing.

Anyway, just out of curiosity, have you tried another input framework?
I'm not really sure if it's worth to include this package for 1 user. :-p

I have tried fcitx but it puts my CPU to 100% for some reasons; I was using fluxbox and the tray icon for fcitx keeps flashing in the toolbar, which makes me suspect fluxbox might be trying to update/refresh the toolbar along with fcitx tray icon too much, thus pushing the CPU usage...

Your reason is totally understandable, it is a niche tool after all and the fact that it's broken on musl doesn't help either 😅

I'm totally happy with keeping it in my forked repo and I'll try to bother you again when I get it to work on musl once I get my hand on more hardware 😆 It's been a pleasant working with you 🤗

[sgn]

I've fixed the build for musl libc, however, it's hung when typing.
Anyway, just out of curiosity, have you tried another input framework?
I'm not really sure if it's worth to include this package for 1 user. :-p

I have tried fcitx but it puts my CPU to 100% for some reasons; I was using fluxbox and the tray icon for fcitx keeps flashing in the toolbar, which makes me suspect fluxbox might be trying to update/refresh the toolbar along with fcitx tray icon too much, thus pushing the CPU usage...

Hm, weird, I've installed fluxbox to try, and fcitx's resource consumption is pretty normal for me.
Anyway, I would recommend using fcitx5 instead, there's fcitx5-m17n to type Vietnamese.

In my experience, fcitx5 is a lot better than fcitx.
I also hear good feedback on ibus-bamboo.

Your reason is totally understandable, it is a niche tool after all and the fact that it's broken on musl doesn't help either sweat_smile

I'm totally happy with keeping it in my forked repo and I'll try to bother you again when I get it to work on musl once I get my hand on more hardware laughing It's been a pleasant working with you hugs

[linhvng]

I didn't know about ibus-bamboo, it works flawlessly! Thank you very much! 🥂 I'm more than happy to have the pull request closed if you are 😄