Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onionshare: remove #32416

Merged
merged 1 commit into from Aug 14, 2021
Merged

onionshare: remove #32416

merged 1 commit into from Aug 14, 2021

Conversation

paper42
Copy link
Member

@paper42 paper42 commented Aug 8, 2021

  • current version is broken
  • updating it is complicated

Closes #31556

@ericonr
Copy link
Member

ericonr commented Aug 9, 2021

Usually the commit message will be remove package instead of just remove.

And you could expand on why updating is complicated.

Otherwise, LGTM.

* doesn't work with Flask 2
@paper42
Copy link
Member Author

paper42 commented Aug 14, 2021

The update is not as hard as I thought: https://github.com/paper42/void-packages/tree/onionshare, but even with the latest version, it still doesn't work with our Flask package, because it needs Flask 1, but we have Flask 2.

@paper42 paper42 merged commit b84a03d into void-linux:master Aug 14, 2021
@paper42 paper42 deleted the onionshare-remove branch August 14, 2021 17:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onionshare-gui fails to start
2 participants