haproxy: enable hitless reloads #32423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdykstra
force-pushed
the
haproxy-hitless-reload
branch
from
4d96e12
to
31f1379
Compare
ericonr
reviewed
Aug 10, 2021
srcpkgs/haproxy/files/haproxy/run
Outdated
| @@ -1,3 +1,5 @@ | |||
| #!/bin/sh | |||
|
|
|||
| exec haproxy -f /etc/haproxy/haproxy.cfg | |||
| exec haproxy -W \ | |||
| -p /var/run/haproxy.pid \ | |||
There was a problem hiding this comment.
I suppose the PID file is needed for this handling?
There was a problem hiding this comment.
It was only storing the PID of the master process, not any of the workers. Removed!
Switch HAProxy to a master/worker (-W) model, allowing for correct handling of HUP signals. To do listening FD handoff, a stats socket with 'expose-fd listeners' needs to be part of the configuration file.
zdykstra
force-pushed
the
haproxy-hitless-reload
branch
from
31f1379
to
98486ad
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch HAProxy to a master/worker (-W) model, allowing for correct
handling of HUP signals. To do listening FD handoff, a stats socket with
'expose-fd listeners' needs to be part of the configuration file.
General
Have the results of the proposed changes been tested?