Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL2: update to 2.0.16. #32444

Merged
merged 2 commits into from
Aug 16, 2021
Merged

SDL2: update to 2.0.16. #32444

merged 2 commits into from
Aug 16, 2021

Conversation

ardadem
Copy link
Contributor

@ardadem ardadem commented Aug 10, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ardadem
Copy link
Contributor Author

ardadem commented Aug 10, 2021

testing locally, please do not merge yet

@ardadem ardadem marked this pull request as draft August 10, 2021 18:31
@ardadem ardadem force-pushed the pr-sdl2-2.0.16 branch 2 times, most recently from 0a20201 to 4c13c02 Compare August 11, 2021 15:32
@ardadem ardadem marked this pull request as ready for review August 11, 2021 15:39
@ardadem
Copy link
Contributor Author

ardadem commented Aug 14, 2021

I'm using it on sway with wayland backend, everything is ok so far. It's ready to be reviewed.

paper42
paper42 reviewed Aug 15, 2021
View reviewed changes
Copy link
Member

@paper42 paper42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I have an issue with SDL2 with the Wayland backend being slow to register my keystrokes in CDDA, but it's not a regression and might not be a fault of SDL2.

srcpkgs/libdecor/template Outdated Show resolved Hide resolved
@ardadem ardadem requested a review from paper42 August 16, 2021 07:28
@ardadem
Copy link
Contributor Author

ardadem commented Aug 16, 2021

@paper42 If you want to test SDL2 more i can recommend https://github.com/ddnet/ddnet.

You need to set DDNET_DRIVER=GLES to use wayland backend with it.

@paper42 paper42 merged commit 0d95455 into void-linux:master Aug 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paper42 paper42 Awaiting requested review from paper42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ardadem @paper42