README.md: put chroot style information together, extend #32446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericonr
reviewed
Aug 10, 2021
README.md
Outdated
| @@ -112,6 +109,11 @@ options it will fail with `EINVAL (Invalid argument)`. | |||
|
|
|||
| #### xbps-uchroot(1) | |||
|
|
|||
| This is the only method that implements functionality of `xbps-src -t`, therefore the | |||
| flag enables it ignoring choice in configuration file. | |||
There was a problem hiding this comment.
Suggested change
| flag enables it ignoring choice in configuration file. | |
| flag enables it and ignores the choice made in configuration files. |
Comment on lines
+115
to
+113
| XBPS utility that uses `namespaces` and must be `setgid` (part of xbps). | ||
|
|
There was a problem hiding this comment.
Suggested change
| XBPS utility that uses `namespaces` and must be `setgid` (part of xbps). | |
| XBPS utility that uses `namespaces` and must be `setgid` (part of `xbps` package in Void Linux). | |
Maybe this should go before the "This is the only..." paragraph?
There was a problem hiding this comment.
It is part of xbps whereever it is extracted, remark is more useful when you are outside Void.
README.md
Outdated
Comment on lines
145
to
147
| bubblewrap, setuid implementation of a subset of user namespaces | ||
| for unprivileged users. Requires no other permissions. | ||
| See <https://github.com/containers/bubblewrap>. |
There was a problem hiding this comment.
Our bwrap isn't suid, it uses user namespaces as well. I think something like "sandbox tool that can use user namespaces or be suid" would be more adequate.
README.md
Outdated
Comment on lines
439
to
440
| If xbps-uunshare does not work because of no `user namespaces` support, | ||
| try other [chroot methods](#chroot-methods). |
There was a problem hiding this comment.
Suggested change
| If xbps-uunshare does not work because of no `user namespaces` support, | |
| try other [chroot methods](#chroot-methods). | |
| If `xbps-uunshare` does not work because of lack of `user_namespaces(7)` support, | |
| try other [chroot methods](#chroot-methods). |
Chocimier
force-pushed
the
chroot-styles
branch
from
14239e4
to
e3d105e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.