Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC]: apparmor: change default mode to complain #32451

Merged
merged 2 commits into from Sep 28, 2021

Conversation

paper42
Copy link
Member

@paper42 paper42 commented Aug 10, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Tasks

  • adopt, @olivier-mauras are you ok with this?
  • support python 3.10 - fix https://gitlab.com/apparmor/apparmor/-/issues/187 or do we want to wait if there will be an apparmor release with a fix before Void switches to Python 3.10?
  • switch to complain mode by default, disabled doesn't make sense, when a user modifies the kernel cmdline to load apparmor, they probably want to use apparmor, so enable at least logging
  • add common shells to logprof.conf
  • fix licenses, libapparmor is LGPL

@ericonr
Copy link
Member

ericonr commented Aug 11, 2021

Logging can be really spammy, but I'd say having it enabled by default makes more sense than not.

Can you change the PR title to reflect this? I think it'd be nice to draw attention to it (maybe add [RFC] too).

@paper42 paper42 changed the title apparmor: update to 3.0.3. [RFC]: apparmor: change default mode to complain Aug 11, 2021
@paper42 paper42 added the enhancement New feature or request label Aug 11, 2021
@ericonr
Copy link
Member

ericonr commented Aug 15, 2021

Also note, I think we'd have to update docs for it.

@paper42 paper42 merged commit bb8c91a into void-linux:master Sep 28, 2021
@paper42 paper42 deleted the apparmor-3.0.3 branch September 28, 2021 09:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants