New package: wluma-1.2.2 #32485
Closed
New package: wluma-1.2.2 #32485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to squash into one commit and change revision to one. |
ericonr
reviewed
Aug 14, 2021
srcpkgs/wluma/template
Outdated
| #wrksrc= | ||
| #create_wrksrc=yes | ||
| build_style=gnu-makefile | ||
| make_cmd="make build" |
There was a problem hiding this comment.
What you want is make_build_target=build
srcpkgs/wluma/template
Outdated
Comment on lines
6
to
7
| #wrksrc= | ||
| #create_wrksrc=yes |
srcpkgs/wluma/template
Outdated
| homepage="https://github.com/maximbaz/wluma" | ||
| distfiles="${homepage}/archive/${version}.tar.gz" | ||
| checksum=dabd6cdf0b9c644af52ad6fad40861829f43c534d42123af2f1f4465b31d5bed | ||
| make_check=no # wluma provides no check suite |
There was a problem hiding this comment.
Suggested change
| make_check=no # wluma provides no check suite | |
| make_check=no # wluma provides no test suite |
srcpkgs/wluma/template
Outdated
| make_cmd="make build" | ||
| hostmakedepends="pkg-config meson ninja" | ||
| makedepends="Vulkan-Headers wayland-devel Vulkan-Tools" | ||
| depends="wayland vulkan-loader mesa-vulkan-intel mesa-vulkan-radeon" |
There was a problem hiding this comment.
wayland and vulkan-loader are detected automatically:
=> wluma-1.2.2_3: running pre-pkg hook: 04-generate-runtime-deps ...
SONAME: libvulkan.so.1 <-> vulkan-loader>=1.0.57.0_1
SONAME: libm.so.6 <-> glibc>=2.32_1
SONAME: libwayland-client.so.0 <-> wayland>=1.10.0_1
SONAME: libc.so.6 <-> glibc>=2.32_1
And I don't think we should force the vulkan drivers either, so I'd be against them. In other words, you can completely remove depends.
srcpkgs/wluma/template
Outdated
| pkgname=wluma | ||
| version=1.2.2 | ||
| revision=3 | ||
| archs="x86_64" |
|
Well, I now see this uses meson, so you should probably use that build style directly. Also, they are rewriting in Rust, so the direction of the package is quite open, I don't think it should be packaged just yet. |
|
Okay, thanks for all the help and advice. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
Have the results of the proposed changes been tested?