New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pavucontrol: update to 5.0. #32510
pavucontrol: update to 5.0. #32510
Conversation
a82c0b3
to
d284b4b
Compare
CC @ericonr |
When this is built with libpulseaudio 15 and runs on a system with libpulseaudio 14, it will fail to start, because of missing symbols? We might want to fix that. You could bump libpulseaudio version in common/shlibs. |
d284b4b
to
7b213cd
Compare
@paper42 Do you mean like this? |
This seems fine, could you split it to a separate commit, it touches a different package. |
@paper42 I've checked shlibs history. Isn't it's always in the same commit or am i missing something? |
They are in the same commit that touches the package which contains the library. We are updating pavucontrol here and noticed that the pulseaudio update forgot to bump the version in shlibs, so I would say that's a separate problem and should be in a separate commit. Of course this is subjective. |
PulseAudio 15 introduced new functionality that packages like pavucontrol will depend on.
7b213cd
to
b3994d9
Compare
I implemented the commit split and merged, thanks. |
reverted in 8a9bdd0 because this update was segfaulting pulseaudio for some reason |
Oh, i'm using it with pipewire and thought it will work with pulseaudio if it's works on pipewire. Sorry about that, but i see u already opened a PR. |
General
Have the results of the proposed changes been tested?
We should merge it after Pulseaudio 15 since it's required for all new features.