Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pavucontrol: update to 5.0. #32510

Merged
merged 2 commits into from Sep 27, 2021
Merged

Conversation

ardadem
Copy link
Contributor

@ardadem ardadem commented Aug 16, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR
Changes:

Support for switching Bluetooth codecs (new in PulseAudio 15.0).
Support for locking card profiles (new in PulseAudio 15.0). Locking a profile prevents PulseAudio from automatically switching away from that profile on plug/unplug events.
New translations: Asturian, Basque, Belarusian, Galician, Hebrew, Kazakh, Norwegian Bokmål, Sinhala, Slovenian
Updated translations: Catalan, Chinese (Simplified), Chinese (Traditional), Croatian, Danish, Dutch, Finnish, French, German, Hungarian, Italian, Japanese, Korean, Lithuanian, Norwegian Nynorsk, Polish, Portugese, Portugese (Brazil), Slovak, Spanish, Swedish, Turkish, Ukrainian.
Some bug fixes.
New dependency: json-glib.
Minimum gtkmm version bumped to 3.22.

We should merge it after Pulseaudio 15 since it's required for all new features.

@ardadem ardadem marked this pull request as draft August 16, 2021 13:20
@ardadem ardadem force-pushed the pr-pavucontrol-5 branch 2 times, most recently from a82c0b3 to d284b4b Compare August 25, 2021 20:56
@ardadem ardadem marked this pull request as ready for review August 25, 2021 21:04
@ardadem
Copy link
Contributor Author

ardadem commented Sep 7, 2021

CC @ericonr

@paper42
Copy link
Member

paper42 commented Sep 7, 2021

When this is built with libpulseaudio 15 and runs on a system with libpulseaudio 14, it will fail to start, because of missing symbols? We might want to fix that. You could bump libpulseaudio version in common/shlibs.

@ardadem
Copy link
Contributor Author

ardadem commented Sep 10, 2021

@paper42 Do you mean like this?

@paper42
Copy link
Member

paper42 commented Sep 10, 2021

Do you mean like this?

This seems fine, could you split it to a separate commit, it touches a different package.

@ardadem
Copy link
Contributor Author

ardadem commented Sep 11, 2021

@paper42 I've checked shlibs history. Isn't it's always in the same commit or am i missing something?

@paper42
Copy link
Member

paper42 commented Sep 11, 2021

I've checked shlibs history. Isn't it's always in the same commit or am i missing something?

They are in the same commit that touches the package which contains the library. We are updating pavucontrol here and noticed that the pulseaudio update forgot to bump the version in shlibs, so I would say that's a separate problem and should be in a separate commit. Of course this is subjective.

ericonr and others added 2 commits September 27, 2021 00:30
PulseAudio 15 introduced new functionality that packages like
pavucontrol will depend on.
@ericonr ericonr merged commit 20cea7a into void-linux:master Sep 27, 2021
@ericonr
Copy link
Member

ericonr commented Sep 27, 2021

I implemented the commit split and merged, thanks.

@paper42
Copy link
Member

paper42 commented Sep 27, 2021

reverted in 8a9bdd0 because this update was segfaulting pulseaudio for some reason

@ardadem
Copy link
Contributor Author

ardadem commented Oct 4, 2021

Oh, i'm using it with pipewire and thought it will work with pulseaudio if it's works on pipewire. Sorry about that, but i see u already opened a PR.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants