ffmpeg: remove ffplay subpackage #32519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved to a separate package due to a cyclic dependency SDL2 - pipewire - ffmpeg (ffplay) - SDL2
ericonr
reviewed
Aug 16, 2021
There was a problem hiding this comment.
However, the suggestion in #32515 (comment) sounds a tad cleaner...
Comment on lines
+39
to
+41
| $CC -o ffplay fftools/ffplay.c fftools/cmdutils.c \ | ||
| -lm -I. \ | ||
| $(pkg-config --cflags --libs sdl2 libavcodec libavdevice libavfilter libavformat libavresample libavutil libpostproc libswresample libswscale) |
There was a problem hiding this comment.
This feels somewhat fragile, since we could miss any defines added by configure scripts and what not. I'd almost say building the entire thing and just taking the binary afterwards is safer.
|
closing in favor of a better solution in #32521 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved to a separate package due to a cyclic dependency
SDL2 - pipewire - ffmpeg (ffplay) - SDL2
I am not sure if this is the best approach.