Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/environment/setup/install.sh: add vdesktop #32575

Closed
wants to merge 8 commits into from

Conversation

jony255
Copy link
Contributor

@jony255 jony255 commented Aug 19, 2021

Install function for installing *.desktop files.

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally such a helper would come with example usage by also fixing some ugly templates to use it. This way we can see it's indeed useful.

return 1
fi

vinstall "$file" 644 "usr/share/applications/${pkgname}" "$targetfile"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.desktop files go directly into usr/share/applications, not per package subdirs...

If $pkgname fits here, it's for the target file, but I don't think it's a good default either.

Also you'd want to use unquoted $targetfile, otherwise it will be passing an empty string as last arg and that's entirely wrong.

Copy link
Contributor Author

@jony255 jony255 Aug 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.desktop files go directly into usr/share/applications, not per package subdirs...

Got it

Also you'd want to use unquoted $targetfile, otherwise it will be passing an empty string as last arg and that's entirely wrong.

I thought so too, but some of the other helpers (vbin, vdoc, vconf, vsconf, vlicense) seemed to be working fine.

@ericonr ericonr added the xbps-src xbps-src related label Aug 19, 2021
@jony255
Copy link
Contributor Author

jony255 commented Aug 19, 2021

Ideally such a helper would come with example usage by also fixing some ugly templates to use it. This way we can see it's indeed useful.

For sure, I'll update some templates

Install function for installing `*.desktop` files.

[ci-skip]
@ericonr
Copy link
Member

ericonr commented Aug 19, 2021

No need to revbump, most of the packages should keep the same contents.

@jony255
Copy link
Contributor Author

jony255 commented Aug 20, 2021

Gotcha!

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 2, 2022
@github-actions github-actions bot closed this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale xbps-src xbps-src related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants