-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libcgroup: update to 2.0 #32623
libcgroup: update to 2.0 #32623
Conversation
continuation of #32231 the commit message is wrong, it should be |
e6f2806
to
c7b1032
Compare
No, run git commit --amend and fix the commit message there. The build is failing now, did you test it on your machine? I think we removed the failing patch in the previous PR, didn't we? |
c7b1032
to
ec5cd87
Compare
git commit --amend is what i run i have adjusted the patches to be compatible with git patches |
but for some reason you are not editing the commit message
If you are not able to edit the commit message interactively, this command should work:
👍
CVE-2018-14348 affects only versions up to (and including) 0.41, so we don't need the patch for 2.0. Didn't we already discuss this? Could you build it on your machine before pushing here to make sure simple mistakes like this don't happen? |
ec5cd87
to
55dd1ad
Compare
fix the commit message |
55dd1ad
to
d876a19
Compare
does the commit message has to contain something special i am currently not aware of? |
The commit message is correct now, thanks. |
@wibed could you test if qomui and mininet still work with this version of libcgroup? |
ill have a look tomorrow if i get to it |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
General
Have the results of the proposed changes been tested?