Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcgroup: update to 2.0 #32623

Closed
wants to merge 1 commit into from
Closed

Conversation

wibed
Copy link

@wibed wibed commented Aug 22, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • [x ] I generally don't use the affected packages but briefly tested this PR

@paper42
Copy link
Member

paper42 commented Aug 22, 2021

continuation of #32231

the commit message is wrong, it should be libcgroup: update to 2.0

@wibed wibed changed the title libcgroup upgrade to 2.0 libcgroup: update to 2.0 Aug 22, 2021
@paper42
Copy link
Member

paper42 commented Aug 22, 2021

No, run git commit --amend and fix the commit message there.

The build is failing now, did you test it on your machine? I think we removed the failing patch in the previous PR, didn't we?

@wibed
Copy link
Author

wibed commented Aug 22, 2021

git commit --amend is what i run

i have adjusted the patches to be compatible with git patches

@paper42
Copy link
Member

paper42 commented Aug 22, 2021

No, run git commit --amend and fix the commit message there.

git commit --amend is what i run

but for some reason you are not editing the commit message

  • did an editor open for you?
  • did you edit the message in it?
  • did you save the file in the editor?

git show will tell you the commit message.

If you are not able to edit the commit message interactively, this command should work:

git commit --amend --no-edit -m "message"

i have adjusted the patches to be compatible with git patches

👍

The build is failing now, did you test it on your machine? I think we removed the failing patch in the previous PR, didn't we?

CVE-2018-14348 affects only versions up to (and including) 0.41, so we don't need the patch for 2.0. Didn't we already discuss this? Could you build it on your machine before pushing here to make sure simple mistakes like this don't happen?

@paper42
Copy link
Member

paper42 commented Aug 23, 2021

fix the commit message

@wibed
Copy link
Author

wibed commented Aug 24, 2021

does the commit message has to contain something special i am currently not aware of?

@paper42
Copy link
Member

paper42 commented Aug 24, 2021

does the commit message has to contain something special i am currently not aware of?

The commit message is correct now, thanks.

@paper42
Copy link
Member

paper42 commented Aug 24, 2021

@wibed could you test if qomui and mininet still work with this version of libcgroup?

@wibed
Copy link
Author

wibed commented Aug 28, 2021

ill have a look tomorrow if i get to it

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 2, 2022
@github-actions github-actions bot closed this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants