Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Unhide-20210124 #32691

Closed
wants to merge 1 commit into from
Closed

New package: Unhide-20210124 #32691

wants to merge 1 commit into from

Conversation

k4leg
Copy link
Contributor

@k4leg k4leg commented Aug 26, 2021

This package is an optional dependency for rkhunter.

General

Have the results of the proposed changes been tested?

  • I generally don't use the affected packages but briefly tested this PR

Other

There are tests in this package but they need root access. What are the ways to enable it (these are files sanity-tcp.sh and sanity.sh)?

@ericonr ericonr added the new-package This PR adds a new package label Aug 27, 2021
@Chocimier
Copy link
Member

Builds on musl with

diff --git a/unhide-linux-compound.c b/unhide-linux-compound.c
index 31f0ee6..a6b597e 100644
--- a/unhide-linux-compound.c
+++ b/unhide-linux-compound.c
@@ -43,6 +43,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #include <sys/syscall.h>
 #include <ctype.h>
 #include <time.h>
+#include <limits.h>
 
 #include "unhide-output.h"
 #include "unhide-linux.h"
diff --git a/unhide-linux-procfs.c b/unhide-linux-procfs.c
index 65d3949..56ca1a2 100644
--- a/unhide-linux-procfs.c
+++ b/unhide-linux-procfs.c
@@ -43,6 +43,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #include <sys/syscall.h>
 #include <ctype.h>
 #include <time.h>
+#include <limits.h>
 
 #include "unhide-output.h"
 #include "unhide-linux.h"
diff --git a/unhide-output.c b/unhide-output.c
index 2d5a834..50c844a 100644
--- a/unhide-output.c
+++ b/unhide-output.c
@@ -25,9 +25,8 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #include <errno.h>
 #ifdef __linux__
    #include <linux/limits.h>
-#else
-   #include <limits.h>
 #endif
+#include <limits.h>
 #include <string.h>
 #include <time.h>
 

@k4leg
Copy link
Contributor Author

k4leg commented Sep 17, 2021

Chocimier, thanks!

-o unhide-linux
$CC $CFLAGS $LDFLAGS --static unhide_rb.c -o unhide_rb
$CC $CFLAGS $LDFLAGS --static unhide-tcp.c unhide-tcp-fast.c \
unhide-output.c -o unhide-tcp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could try to sell something like a simple Makefile or meson to upstream?
Manually creating compiles command in the template will surely bite use sooner or later.

Also it would be nice if the patch would also be sent to upstream.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a script in upstream build_all.sh. Maybe it's worth using it then?

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 2, 2022
@github-actions github-actions bot closed this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants