-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: reuse-0.13.0 #32746
New package: reuse-0.13.0 #32746
Conversation
|
|
PyPI tarballs also remove tests, so I think it would be nicer to use the non-pypi tarballs when there are tests to run. |
Makes sense if this is case for these packages, but don't that depend on setup.py? |
setup.py test is the old way of running tests, for modern projects, we can use pytest from python3-pytest. |
I mean boolean.py pypi tarball includes tests. |
I get your point now. Some projects have their tests in pypi tarballs, some don't, so we could check for each package. |
I don't understand why but the tests fail in CI (see this). With a local build everything is fine. Perhaps this will change after switching from tox to other.
Btw I saw in some packages tests are missing because some dependencies are missing. Is it okay to do the same or is it better to pack them? This is why I used tox. |
Best is to selectively disable tests that fail for known reason, and report other upstream. |
See https://reuse.software for more info.
General
Have the results of the proposed changes been tested?