Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: reuse-0.13.0 #32746

Merged
merged 5 commits into from
Sep 17, 2021
Merged

New package: reuse-0.13.0 #32746

merged 5 commits into from
Sep 17, 2021

Conversation

k4leg
Copy link
Contributor

@k4leg k4leg commented Aug 29, 2021

See https://reuse.software for more info.

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@paper42 paper42 added the new-package This PR adds a new package label Aug 29, 2021
@Chocimier
Copy link
Member

  • no new py2 packages are accepted
  • depending on minimal version of module is going to stale, please either provide tool to keep it up to date on update, or drop
  • testing with tox undex xbps-src is useless, try good deprecated things
  • make_check= has to be justified
  • no need do depend on interpreter when depending on module

@Chocimier
Copy link
Member

  • please use pypi as homepage for packages not fetched from pypi, this helps find upstream in case it moves

@paper42
Copy link
Member

paper42 commented Aug 30, 2021

  • please use pypi as homepage for packages not fetched from pypi, this helps find upstream in case it moves

PyPI tarballs also remove tests, so I think it would be nicer to use the non-pypi tarballs when there are tests to run.

@Chocimier
Copy link
Member

nicer to use the non-pypi tarballs

Makes sense if this is case for these packages, but don't that depend on setup.py?

@paper42
Copy link
Member

paper42 commented Aug 30, 2021

nicer to use the non-pypi tarballs

Makes sense if this is case for these packages, but don't that depend on setup.py?

setup.py test is the old way of running tests, for modern projects, we can use pytest from python3-pytest.

@Chocimier
Copy link
Member

I mean boolean.py pypi tarball includes tests.

@paper42
Copy link
Member

paper42 commented Aug 30, 2021

I mean boolean.py pypi tarball includes tests.

I get your point now. Some projects have their tests in pypi tarballs, some don't, so we could check for each package.

@k4leg
Copy link
Contributor Author

k4leg commented Aug 30, 2021

* `make_check=` has to be justified

I don't understand why but the tests fail in CI (see this). With a local build everything is fine. Perhaps this will change after switching from tox to other.

* testing with tox undex xbps-src is useless, try good deprecated things

Btw I saw in some packages tests are missing because some dependencies are missing. Is it okay to do the same or is it better to pack them? This is why I used tox.

@Chocimier
Copy link
Member

Best is to selectively disable tests that fail for known reason, and report other upstream.

srcpkgs/python3-binaryornot/template Outdated Show resolved Hide resolved
srcpkgs/python3-binaryornot/template Outdated Show resolved Hide resolved
srcpkgs/python3-debian/template Outdated Show resolved Hide resolved
srcpkgs/python3-debian/update Outdated Show resolved Hide resolved
@k4leg k4leg mentioned this pull request Sep 4, 2021
3 tasks
srcpkgs/reuse/template Outdated Show resolved Hide resolved
srcpkgs/reuse/template Outdated Show resolved Hide resolved
srcpkgs/reuse/template Outdated Show resolved Hide resolved
srcpkgs/reuse/template Outdated Show resolved Hide resolved
@Chocimier Chocimier merged commit 0c73e4c into void-linux:master Sep 17, 2021
@k4leg k4leg deleted the New-package-reuse branch September 17, 2021 18:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants