Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: webhook-2.8.0 #32813

Merged
merged 1 commit into from Feb 15, 2022
Merged

New package: webhook-2.8.0 #32813

merged 1 commit into from Feb 15, 2022

Conversation

classabbyamp
Copy link
Member

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Does it build and run successfully?

(Please choose at least one native build and, if supported, at least one cross build. More are better.)

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl (cross)
    • armv7l (cross)
    • armv6l-musl (cross)

@classabbyamp
Copy link
Member Author

classabbyamp commented Sep 3, 2021

Which would be the best approach?

  1. add the empty /etc/webhook/hooks.json
  2. copy the example hooks.json to /etc/webhook
  3. make_dirs="/etc/webhook 0644 root root" (what I do now)

@ericonr ericonr added the new-package This PR adds a new package label Sep 3, 2021
srcpkgs/webhook/files/webhook/conf Outdated Show resolved Hide resolved
srcpkgs/webhook/files/webhook/run Outdated Show resolved Hide resolved
srcpkgs/webhook/files/webhook/run Outdated Show resolved Hide resolved
srcpkgs/webhook/files/webhook/run Outdated Show resolved Hide resolved
srcpkgs/webhook/files/webhook/run Outdated Show resolved Hide resolved
@classabbyamp
Copy link
Member Author

PR updated to add a basic default config file and set up the service to run in an unprivileged system account instead of root. @ericonr can I get a re-review on this?

@classabbyamp
Copy link
Member Author

@paper42 all ready

@paper42 paper42 merged commit 7f18f76 into void-linux:master Feb 15, 2022
@classabbyamp classabbyamp deleted the webhook branch February 15, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants